cmd/utils: don't crash on nonexistent datadir#22738
Merged
Merged
Conversation
rjl493456442
approved these changes
Apr 26, 2021
Member
rjl493456442
left a comment
rjl493456442
left a comment
There was a problem hiding this comment.
Perhaps we should figure out a better way to handle it. But the temporary fix is also good to me.
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
9 tasks
9 tasks
This was referenced Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #22720
Problem is that if the datadir is opened read only and does not exist, the
leveldb.Newcommand will fail.Previous behavior was to create the datadir if non-existent.
This PR restores previous behavior